[pull] trunk from Automattic:trunk #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
An `h3` (`###` markdown) in the CI annotation results in a message that clashes visually with the rest of the annotations. See for example https://buildkite.com/automattic/simplenote-ios/builds/1146
The `ios_check_beta_deps` action doesn't discriminated between internal (1st party) and external (3rd party) dependencies. https://github.com/wordpress-mobile/release-toolkit/blob/ee03eb9232597fd812c18d3fb0fbf91130facf97/lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_check_beta_deps.rb
We don't want to use the `BUILDKITE_` prefix workaround.
This way, we'll always be sure the gems resolved to a version that includes this new feature we want to use: `buildkite_pipeline_upload`
4.54 was not shipped so we can use its notes in 4.55
The previous AppCenter version failed the build with a "rsync.samba" error due to it having script sandboxing enabled. Noticed that: - The only breaking change from version 4 to 5 is the change in minimum deployment target. See https://github.com/microsoft/appcenter-sdk-apple/blob/8b039c9de609bd58ea7526c60954194cd1b3a94e/CHANGELOG.md#version-500 - The App Store build does not import AppCenter - AppCenter will be decommissioned in March 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )